make INLINE compatible with C99 #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C99 has a different inline behaviour but provides the gnu_inline attribute to switch to the old behaviour. it it suggested to check __GNUC_STDC_INLINE__ if the new behaviour is active.
MushMal
approved these changes
Mar 14, 2022
|
Thanks for your contribution. Closing in favor of #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
C99 has an incompatible inline behaviour but GCC provides the
gnu_inlineattribute to switch to the old behaviour.It it suggested to check via
__GNUC_STDC_INLINE__if the new behaviour is active.Without this change you get several warnings (or errors with -Werror) like this one when compiled in C99:
CommonDefs.h:622:14: error: inline function 'defaultMemAlloc' declared but never defined [-Werror]Support for
gnu_inlineand__GNUC_STDC_INLINE__was introduced in GCC 4.1.3 (current check is for 4.x) but it might be an option to always use thegnu_inlineattribute.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.